Apache Commons logo Commons Lang

Tag List Report

The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.

Tag Class Total number of occurrences Tag strings used by tag class
Needs Work 56 TODO, FIXME, XXX
Noteable Markers 21 NOTE, NOPMD, NOSONAR

Each tag is detailed below:

Needs Work

Number of occurrences found in the code: 56

org.apache.commons.lang3.AbstractLangTest Line
Do more to make sure memory is not retained, maybe like Log4j checks for it. 35
org.apache.commons.lang3.ArraySorter Line
For 4.0, rename to ArraySort, since we cover the sort() method here, see also ArrayFill. 25
org.apache.commons.lang3.CharRange Line
This is no longer public and will be removed later as CharSet is moved to depend on Range. 34
org.apache.commons.lang3.CharSequenceUtils Line
Do we assume searchChar is usually relatively small; // If so then calling toString() on it is better than reverting to // the green implementation in the else block return ((String) cs).indexOf((String) searchChar, start); } else { 64
Implement rather than convert to String return cs.toString().indexOf(searchChar.toString(), start); } 69
org.apache.commons.lang3.ClassLoaderUtilsTest Line
How to better test considering this test may be called from an IDE and Maven? 37
How to better test considering this test may be called from an IDE and Maven? 43
org.apache.commons.lang3.LocaleUtils Line
Should this return the default locale? 402
org.apache.commons.lang3.ObjectUtils Line
Move to ComparableUtils. </p> 284
Move to ComparableUtils. </p> 299
Java 11 Use Optional#isEmpty() 976
Move to ComparableUtils. </p> 1018
Move to ComparableUtils. </p> 1088
org.apache.commons.lang3.RandomUtilsTest Line
should be <max? 73
should be <max? 80
should be <max? 89
should be <max? 99
org.apache.commons.lang3.StringEscapeUtils Line
throw "illegal character: \92" as an Exception if a \ on the end of the Java (as per the compiler)? 313
org.apache.commons.lang3.StringEscapeUtilsTest Line
I think this should hold, needs further investigation String unescapedFromEntity = StringEscapeUtils.unescapeHtml4("𝍢"); assertEquals("High Unicode should have been unescaped", original, unescapedFromEntity); 205
refine API for escaping/unescaping specific HTML versions 215
org.apache.commons.lang3.Validate Line
when breaking BC, consider returning value 95
when breaking BC, consider returning value 116
when breaking BC, consider returning value 136
when breaking BC, consider returning value 157
when breaking BC, consider returning value 178
when breaking BC, consider returning value 202
when breaking BC, consider returning value 272
when breaking BC, consider returning value 293
when breaking BC, consider returning value 313
when breaking BC, consider returning value 334
when breaking BC, consider returning value 355
when breaking BC, consider returning value 379
when breaking BC, consider returning type 401
when breaking BC, consider returning type 426
when breaking BC, consider returning obj 448
when breaking BC, consider returning obj 471
when breaking BC, consider returning input 616
when breaking BC, consider returning input 639
org.apache.commons.lang3.exception.ExceptionUtils Line
Remove in Lang 4 49
Remove in Lang 4 253
org.apache.commons.lang3.reflect.FieldUtils Line
is this workaround still needed? lang requires Java 6 Sun Java 1.3 has a bugged implementation of getField hence we write the code ourselves 182
org.apache.commons.lang3.reflect.MemberUtils Line
extract an interface to implement compareParameterSets(...)? 32
org.apache.commons.lang3.reflect.TypeUtilsTest Line
Is this correct? 605
Is this correct? 607
This test returns true unlike the test above. Is this a bug in this test or in the main code? 864
org.apache.commons.lang3.text.StrBuilder Line
make private? 277
make private? 280
org.apache.commons.lang3.text.translate.NumericEntityUnescaper Line
?: Create an OptionsSet class to hide some of the conditional logic below 66
org.apache.commons.lang3.text.translate.UnicodeEscaper Line
Handle potential + sign per various Unicode escape implementations 129
org.apache.commons.lang3.time.AbstractFormatCache Line
Before making public move from getDateTimeInstance(Integer, ...) to int; or some other approach. 37
org.apache.commons.lang3.time.DurationFormatUtils Line
Compare performance to see if anything was lost by losing this optimization. 547
Need to handle escaping of ' 709
org.apache.commons.lang3.time.DurationUtils Line
when using Java >= 9: Use TimeUnit.toChronoUnit(). 205
org.apache.commons.lang3.time.FastDateParser Line
Use of getZoneStrings() is discouraged per its Javadoc. 550
org.apache.commons.lang3.time.FastDateParser_TimeZoneStrategyTest Line
Why don't all short IDs parse, even on Java 8? 91
Why don't all short IDs parse, even on Java 8? 109

Noteable Markers

Number of occurrences found in the code: 21

org.apache.commons.lang3.CharSequenceUtils Line
- we must do a forward traversal for this to avoid duplicating code points 265
org.apache.commons.lang3.ClassUtils Line
From v2.2, this method handles {@code Void.TYPE}, returning {@code Void.TYPE}. </p> 1558
org.apache.commons.lang3.StringUtils Line
This method changed in 2.0. It now more closely matches Perl chomp. </p> 662
This method changed in version 2.0. It now more closely matches Perl chomp. For the previous behavior, use {@link #substringBeforeLast(String, String)}. This method uses {@link String#endsWith(String)}. </p> 709
LINT this intentionally uses == to allow for both null 862
LINT this intentionally uses == to allow for both null 963
This method changed in Lang version 2.0. It no longer trims the CharSequence. That functionality is available in isBlank(). </p> 3537
logic duplicated below START 6461
logic mostly below END 6476
logic mostly duplicated above START 6515
logic duplicated above END 6530
LINT str cannot be null here 8097
This method changed in Lang version 2.0. It no longer performs a word based algorithm. If you only use ASCII, you will notice no change. That functionality is available in org.apache.commons.lang3.text.WordUtils. </p> 8620
org.apache.commons.lang3.builder.EqualsBuilder Line
we cannot store the actual objects in a HashSet, as that would use the very hashCode() we are in the process of calculating. 99
org.apache.commons.lang3.builder.HashCodeBuilder Line
we cannot store the actual objects in a HashSet, as that would use the very hashCode() we are in the process of calculating. 125
This method uses >> and not >>> as Effective Java and Long.hashCode do. Ideally we should switch to >>> at some stage. There are backwards compat issues, so that will have to wait for the time being. See LANG-342. 732
org.apache.commons.lang3.builder.ToStringStyle Line
It assumes that the toString has been created from the same ToStringStyle. </p> 1730
It assumes that the toString has been created from the same ToStringStyle. </p> 1748
org.apache.commons.lang3.text.ExtendedMessageFormatTest Line
FAILING - currently sub-formats not supported 135
FAILING - currently sub-formats not supported 152
org.apache.commons.lang3.time.StopWatch Line
As from v2.1, the methods protect against inappropriate calls. Thus you cannot now call stop before start, resume before suspend or unsplit before split. </p> 55